Hey, On 05/02/2012 04:43 PM, Nathan Williams wrote: > +networkmanager-list > > On Wed, May 2, 2012 at 10:43 AM, Nathan Williams <n...@google.com > <mailto:n...@google.com>> wrote: > > On 05/01/2012 06:07 PM, Nathan Williams wrote: > > Subject: [PATCH 1/5] novatel: Add support for connecting to > specific APNs and > > specifying username/password. > > > > While here, pass through the other relevant bearer properties. > > Did you have time to check the 'bearer-properties' branch I > wrote about > some time ago? That branch makes it unnecessary to have bearers > implement user/password properties themselves. > > > It certainly seemed like a good idea, and would simplify this, but I > didn't think it had been merged. I hope you hadn't been waiting on > me.... >
Actually, I had almost forgot about that branch :-) No big deal, I'll merge that patch as it is (when the quote_string() comes in), and then update the branch before merging it. > > > > + apn = mm_at_serial_port_quote_string > (mm_broadband_bearer_get_3gpp_apn (bearer)); > > + user = mm_at_serial_port_quote_string (self->priv->user); > > + password = mm_at_serial_port_quote_string > (self->priv->password); > > + command = g_strdup_printf ("$NWQMICONNECT=,,,,,,%s,,,%s,%s", > > + apn, user, password); > > mm_at_serial_port_quote_string() is not in git master yet. I > remember a > thread talking about quoting strings, but don't recall getting a > patch > about it. Could you also post that one? > > > Will do. I had forgotten that I was using it in both of my plugins, > and meant to include it in the stack with my Samsung changes. > Ok. -- Aleksander _______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list