Excellent point. Revised.
- Nathan
On Wed, May 2, 2012 at 6:24 AM, Aleksander Morgado <aleksan...@lanedo.com>wrote:
> On 05/01/2012 06:09 PM, Nathan Williams wrote:
> > +static gboolean
> > +poll_connection (MMBroadbandBearerNovatel *bearer)
> > +{
> > + mm_base_modem_at_command (
> > + bearer->priv->connection_modem,
> > + "$NWQMISTATUS",
> > + 3,
> > + FALSE,
> > + (GAsyncReadyCallback)poll_connection_ready,
> > + bearer);
> > + return TRUE;
> > +}
>
> Why the extra connection_modem object in the private struct? There's
> already a proper reference to the modem object in the MMBearer parent,
> which can be retrieved getting the MM_BEARER_MODEM property.
>
> --
> Aleksander
>
0001-novatel-Poll-for-whether-the-connection-still-exists.patch
Description: Binary data
_______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
