On Tue, 2013-04-16 at 07:05 +0100, Fabio Erculiani wrote: > If --with-session-tracking=systemd, but logind is not currently running, the > code > now falls back to ConsoleKit. This is particularly useful for covering > the interim, while waiting for distros to abandon ConsoleKit completely.
There's lots of reimplementations of things like this; polkit has one, gnome-session has one. It'd be a lot nicer if it was refactored into something copy&paste-able. It looks like you're not deleting nm-session-monitor-ck.c, but it's unused? I find the #ifdef approach a bit ugly; it'd be more elegant to have real GObjects and have an egg_session_monitor_get() which checks for logind exactly once, and returns an instance of EggSessionMonitorSystemd or EggSessionMonitorCK as appropriate, rather than constantly checking and having the code for both rolled together. _______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
