Mon, Mar 10, 2014 at 07:11:01PM CET, d...@redhat.com wrote:
>On Sat, 2014-03-08 at 12:48 +0100, Jiri Pirko wrote:
>> The problem is that initscripts rewrite DEVICETYPE in case TYPE is specified
>> which prevents team port from being configured. Fix this by removing TYPE.
>> 
>> Signed-off-by: Jiri Pirko <j...@resnulli.us>
>> 
>> diff --git a/src/settings/plugins/ifcfg-rh/writer.c 
>> b/src/settings/plugins/ifcfg-rh/writer.c
>> index baa851a..b687bee 100644
>> --- a/src/settings/plugins/ifcfg-rh/writer.c
>> +++ b/src/settings/plugins/ifcfg-rh/writer.c
>> @@ -1742,6 +1742,7 @@ write_connection_setting (NMSettingConnection *s_con, 
>> shvarFile *ifcfg)
>>              else if (nm_setting_connection_is_slave_type (s_con, 
>> NM_SETTING_TEAM_SETTING_NAME)) {
>>                      svSetValue (ifcfg, "TEAM_MASTER", master, FALSE);
>>                      svSetValue (ifcfg, "DEVICETYPE", TYPE_TEAM_PORT, FALSE);
>> +                    svSetValue (ifcfg, "TYPE", NULL, FALSE);
>>              }
>>      }
>
>Looks good.  This is being followed in Red Hat bug 1074160 and the
>jk/rh1074160-team-port branch, FWIW.

Cheers Dan. Just note that the follow-up read patch is needed as well.

>
>Dan
>
_______________________________________________
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Reply via email to