On Fri, 2015-03-13 at 13:20 -0500, Dan Williams wrote: > Hi Thomas, > > About th/keyfile... > > > libnm: add _nm_utils_hash_values_to_ptrarray() function > > What about g_hash_table_get_values() instead? It returns the values as > a GList* instead of a GPtrArray, were you just worried about memory > allocation here?
I forgot about g_hash_table_get_values(), but yes, the idea was to keep additional overhead small. I refactored it again, so that no malloc is needed. Repushed. > The rest looks OK to me. Do we need to update any testcases for the > sort ordering? I think not, they still work for me. The sort order before was unspecified. Thomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
