On Fri, 2015-10-23 at 11:50 -0500, Dan Williams wrote:
> Because Bluez5 dropped DUN support, NM must do that manually which
> includes emulating the "connected" property for Bluetooth devices
> when
> DUN is used.  It does this by setting priv->connected = TRUE in
> nm_bluez_device_connect_finish().
> 
> But for PAN, when NM does process the 'connected' property change
> notification, priv->connected is already TRUE and
> _take_variant_property_connected() does nothing.  Hence the
> corresponding GObject property notification is not emitted,
> nm-device-bt.c::check_connect_continue() will never return success,
> and
> the activation times out.
> 
> To fix this, ensure that GObject notifications are emitted when the
> device is connected, even if emulated internally.
> 


Patch looks good to me.
I merged the patch:

master: 
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=0e3086e8b885164f24b43a1060cb1f87a62723a8

nm-1-0: 
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=cccb8fe5e6945085d43050411c1ced26453d85df


Thomas

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Reply via email to