Thanks for the patch, Rafaël. I'm not sure it's correct, though. The VPN plugin probably should probably only emit "Config" signal and not "IP4Config" when it has no IPv4 configuration.
On Tue, 2015-11-03 at 19:31 +0100, Rafaël Carré wrote: > IPv4 config can be set manually > --- > src/vpn-manager/nm-vpn-connection.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/vpn-manager/nm-vpn-connection.c b/src/vpn- > manager/nm-vpn-connection.c > index 0c0ac1c..fc49304 100644 > --- a/src/vpn-manager/nm-vpn-connection.c > +++ b/src/vpn-manager/nm-vpn-connection.c > @@ -1419,10 +1419,7 @@ nm_vpn_connection_ip4_config_get > (NMVpnConnection *self, GVariant *dict) > address.source = NM_IP_CONFIG_SOURCE_VPN; > nm_ip4_config_add_address (config, &address); > } else { > - _LOGE ("invalid IP4 config received!"); > - g_object_unref (config); > - nm_vpn_connection_config_maybe_complete (self, > FALSE); > - return; > + _LOGW ("invalid IP4 config received!"); > } > > if (g_variant_lookup (dict, NM_VPN_PLUGIN_IP4_CONFIG_DNS, > "au", &iter)) { Lubo _______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list