On Fri, 2016-01-22 at 12:50 +0100, Matthias Berndt wrote: > Hi Beniamino et al, > > networkmanager-openvpn doesn't currently handle <tls-auth> blobs > correctly. I've modified networkmanager-openvpn to support this > functionality and fixed two minor bugs in the process. I'd be > thrilled if you could comment on the patch. > > a presto, > Matthias >
Hi Matthias, thank you, this looks good. Any chance you could also add a unit-test for it? See tests/test- import-export, which you run via `make check`. And what are the 2 bugs you mention? - } while (!*p[0]); \ + } while (*p[0] == '\0' || *p[0] == '#' || *p[0] =... and - line = &p; + *line = p; Would be worth to be a separate commit. Thanks again. Thomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
