On Mon, 2018-01-08 at 13:18 +0100, Thomas Haller wrote:
> Hi,
>
> On Fri, 2018-01-05 at 14:17 +0100, Iñigo Martínez wrote:
> > In a recent commit 1402fa7487b29fc1ea39a6bf7659fee7f30bb0e0 a new
> > way for testing Red Hat compatible distributions had been added.
> >
> > This new testing approach has also been added to meson.
> > ---
> > meson.build | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index cc704a47a..16195467a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -207,8 +207,7 @@ glib_dep = declare_dependency(
> >
> > check_distro = join_paths(meson.source_root(), 'check-distro.py')
>
> check-distro.py does "os.path.isfile(location)", hence it does not
> work
> for /etc/sysconfig/network-scripts (which is a directory).
>
> Also, how about moving check-distroy.py to "tools/meson-test-file"?
>
> Also, maybe use a shell script instead?
> #!/bin/sh
> for NAME; do
> test -e "$NAME" || exit 1
> done
>
>
> Also, wouldn't not something like
> if run_command('test', '-e', '/etc/sysconfig/network-scripts') == 0
> be simpler?Hi Iñigo, merged v2 as https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=08a91094594fe73aa3e1a7185074a040be15e94f best, Thomas Hi
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
