On Tue, 2019-02-26 at 09:03 +0200, Cristian Crinteanu wrote: > .. > src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c: In function > ‘discover_mac_address’: > src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c:572:15: error: > storage size of ‘ifr’ isn’t known > struct ifreq ifr; > ^~~ > src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c:590:32: error: > ‘IFNAMSIZ’ undeclared (first use in this function); did you mean > ‘NMP_IFNAMSIZ’? > strncpy(ifr.ifr_name, device, IFNAMSIZ-1); > ^~~~~~~~ > NMP_IFNAMSIZ > src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c:590:32: note: > each undeclared identifier is reported only once for each function it > appears in > src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c:572:15: warning: > unused variable ‘ifr’ [-Wunused-variable] > struct ifreq ifr; > ^~~ > make[2]: *** [Makefile:15086: src/settings/plugins/ifcfg- > rh/libnms_ifcfg_rh_core_la-nms-ifcfg-rh-reader.lo] Error 1 > make[2]: Leaving directory '/home/yoda/rpmbuild/BUILD/NetworkManager- > 1.14.6' > make[2]: *** Waiting for unfinished jobs.... > ... > make[2]: Leaving directory '/home/yoda/rpmbuild/BUILD/NetworkManager- > 1.14.6' > make[1]: *** [Makefile:17787: all-recursive] Error 1 > make: *** [Makefile:7870: all] Error 2 > error: Bad exit status from /var/tmp/rpm-tmp.2zCe40 (%build) > Any ideea ? > Thx!
Hi, It doesn't seem you are using 1.14.6. In file "src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c" the quoted line is not that way. also, `git grep 'strncpy.*IFNAMSIZ'` gives no result on 1.14.6. Neither does `git grep 'IFNAMSIZE-1'` [1] https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c?id=1.14.6 best, Thomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
