Hi Dai, The fix looks good. Thanks for enumerating the scenarios you tested. If you haven't already done so, please add this test output to the bug report. (you'll also need it for the RTI).
Jeff On Jan 12, 2009, at 12:19 PM, Dai Ngo wrote: > Hi, > > I'd like to have a code review for the fix of CR 6583602: > > http://cr.opensolaris.org/~dain/6583602/ > <http://cr.opensolaris.org/%7Edain/6583602/> > > I wrote a small C test program and tested it with the following > patterns: > > solana_ds.dainx[534] a.out "/foo" > ORIG=/foo --> foo > FIXED=foo > solana_ds.dainx[535] a.out "/.foo" > ORIG=/.foo --> foo > FIXED=.foo > solana_ds.dainx[536] a.out "/..foo" > ORIG=/..foo --> ..foo > FIXED=..foo > solana_ds.dainx[537] a.out ".//./foo" > ORIG=.//./foo --> foo > FIXED=foo > solana_ds.dainx[538] a.out ".//./.foo" > ORIG=.//./.foo --> foo > FIXED=.foo > solana_ds.dainx[539] a.out ".//./..foo" > ORIG=.//./..foo --> ..foo > FIXED=..foo > > solana_ds.dainx[540] a.out "./foo" > ORIG=./foo --> foo > FIXED=foo > solana_ds.dainx[541] a.out "./.foo" > ORIG=./.foo --> foo > FIXED=.foo > solana_ds.dainx[542] a.out "./..foo" > ORIG=./..foo --> ..foo > FIXED=..foo > solana_ds.dainx[543] a.out "../..foo" > ORIG=../..foo --> ../..foo > FIXED=../..foo > > Thanks, > -Dai > _______________________________________________ > nfs-discuss mailing list > nfs-discuss at opensolaris.org
