On 03/02/10 16:11 -0600, Tom Haynes wrote:
>  usr/src/uts/common/fs/nfs/nfs4_srv.c:
> 
>  1178         }
>  1179         /* If necessary, convert to UTF-8 for ill behaved clients */
>  1180 1181         ca = (struct sockaddr 
>  *)svc_getrpccaller(req->rq_xprt)->buf;
> 
> 
>  I'd prefer a line between 1178 and 1179. And take away 1180.
> 
>  The first point is more of a concern.
> 
>  ----
> 
>  Actually, all of the instances of that comment could probably go. It is
>  copied everywhere that nfscmd_convname() appears. It would be better served
>  as a comment to the function.
> 

done.

>  ======
> 
>  usr/src/uts/common/fs/nfs/nfs_server.c
> 
> 
>  Line 3219 does not need to be added.
> 

typo fixed


thanks
Jan

Reply via email to