Hi, William Allen Simpson wrote on Fri, Aug 21, 2015 at 03:32:48AM -0400: > >My comments for the libntirpc update still stand ( > >https://review.gerrithub.io/#/c/243818/ ) > > Matt didn't commit his merged patch into the github linuxbox2, > making it impossible for me to cherry-pick it directly onto -dev-14. > This is synthesized from several patches.
Ah, ok. You can also fetch from gerrithub e.g. "git fetch gerrit refs/changes/19/243819/2" for matt's commit, but yeah not very convenient. > I've found some other commits Matt had laying around, and added them > here, but they don't fix your specific complaint. > > One of those was some CMAKE, and it seems OK. Not tested. It > had the updated commit message.... Hmm, Matt's commit does have the camke change, your's doesn't. Good of you to bring it up I totally missed that. How can you enable BLKIN if you can't set the build option? > >(Nitpick for next time, did you try pushing with the original > >Change-Id? I think it'll let you even if you're not commit author, so > >you can update the original change without creating a duplicate + > >need to abandon either) > > This is the change-id on his last linuxbox2 commit. If I'd noticed, > I'd have copy and pasted them together or something. > > Though I remember not being able to update somebody else's review > patch before. Hmm yeah I remember gerrit refusing to commit other's, but I think it should allow updating other's commit. I'm sure Frank has done it at some point but it might be because he's in god mode. That being said, you just pushed a commit authored by Matt, so I think it'll be ok. One way to find out :) -- Dominique ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
