>From Malahal <[email protected]>: Malahal has uploaded a new change for review.
https://review.gerrithub.io/248667 Change subject: Fix incorrect atime/mtime with EXCLUSIVE4 create ...................................................................... Fix incorrect atime/mtime with EXCLUSIVE4 create The client was creating files with EXCLUSIVE4 method, and ganesha server uses atime and mtime metadata fields to store the provided verifier. According to the RFC paragraph below, the server needs to notify the client about what metadata fields it used to store the verifier so that the client can later send a setattar to update those fields. We don't do that, so the client never updates atime or mtime. In the end, we end up files with bogus atime (and mtime). Just mounting a ganesha export in NFSv4.0, and then doing "cp <local-file> <new-file-in-NFS-mount>" will reproduce the issue and can be verified with 'stat' command. And here is the RFC paragraph from RFC 7530: If the server uses an attribute to store the exclusive create verifier, it will signify which attribute was used by setting the appropriate bit in the attribute mask that is returned in the results. Also fixed sattr.mask when sattr.mode is set. Change-Id: Ic0a0d4af9d13268d574b79dedc269a7f67a17872 Signed-off-by: Malahal Naineni <[email protected]> --- M src/Protocols/NFS/nfs4_op_open.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/248667/1 -- To view, visit https://review.gerrithub.io/248667 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0a0d4af9d13268d574b79dedc269a7f67a17872 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal <[email protected]> Gerrit-Reviewer: CEA-HPC <[email protected]> ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
