>From Daniel Gryniewicz <[email protected]>: Daniel Gryniewicz has uploaded a new change for review.
https://review.gerrithub.io/248807 Change subject: Move ntirpc to a CMake external ...................................................................... Move ntirpc to a CMake external Having ntirpc as a submodule for Ganesha is useful for development, but it makes it harder to build packages for distribution, precludes using a system version of ntirpc, and makes development of ntirpc itself more difficult. Move to using a CMake external. This checks for the existence of a system-wide install of ntirpc that is suitable, and uses it if found. Othewise, CMake checks out the correct version of ntirpc from upstream at build time, and builds and installs it before the ganesha build happens. This should be largely transparent to current Ganesha developers, as the result will still be a fixed commit of ntirpc checked out in the source tree at src/libntirpc. The differences are: Negative: - ntirpc is not checked out until build time Positive: - No more forgetting to update submodules - No more accidentally committing an older version of ntirpc Change-Id: Iee5061a04f998cfd8db2915442ff59189a6d410c Signed-off-by: Daniel Gryniewicz <[email protected]> Squash into ntirpc Change-Id: Iba6dc060a036217683b97b6790756fa723cf238c Signed-off-by: Daniel Gryniewicz <[email protected]> --- M .gitmodules M src/CMakeLists.txt M src/FSAL/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/Protocols/CMakeLists.txt M src/Protocols/NLM/CMakeLists.txt M src/RPCAL/CMakeLists.txt M src/SAL/CMakeLists.txt M src/cache_inode/CMakeLists.txt A src/cmake/modules/FindNTIRPC.cmake A src/cmake/modules/LibFindMacros.cmake M src/idmapper/CMakeLists.txt D src/libntirpc M src/nfs-ganesha.spec-in.cmake M src/os/CMakeLists.txt M src/support/CMakeLists.txt 16 files changed, 334 insertions(+), 64 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/248807/1 -- To view, visit https://review.gerrithub.io/248807 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba6dc060a036217683b97b6790756fa723cf238c Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz <[email protected]> ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
