If you are working on a complex patch set that will need several reviews, and you have to rebase it to the latest dev, AND you want to make updates to the patch set in response to review comments: Do two separate pushes to gerrit. That way, when a reviewer looks at the diff between versions of a patch, they can skip the rebase changes (which will show all the changes between the two dev tags and not your changes). Obviously you MAY have to do manual merge stuff, and that SHOULD be done in the rebase push, and that will be a pain to look for.
If you do side-by-side diff in gerrit, it's real easy to bounce around between various versions of the patch for a given file. I hope that's helpful to folks. Thanks Frank --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
