On 06/28/2017 08:41 PM, William Allen Simpson wrote:
This is a good programming practice of long-standing value.Why of why do these evil commit tests keep creeping in? bill@simpson91:~/rdma/nfs-ganesha$ git commit --amend -a WARNING: Comparisons should place the constant on the right side of the test #17: FILE: src/MainNFSD/nfs_rpc_dispatcher_thread.c:1777: + if (XPRT_DONE <= stat) {
I disagree. I think this is a bad practice that is hard to read. Daniel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
