Hi Dan,
This change could lead to a thread trying to acquire qlock while
holding the same(see below). The *lock_already_held* flag is now
removed.
#2 0x00007faf71f7dc08 in pthread_mutex_lock () from /lib64/libpthread.so.0
#3 0x00000000005227c0 in _mdcache_lru_unref (entry=0x7faee0dbe100,
flags=0, func=0x58b8c0 <__func__.23709> "lru_reap_impl", line=691)
at
/usr/src/debug/nfs-ganesha-2.5.1-0.1.1-Source/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1874
#4 0x000000000051e914 in lru_reap_impl (qid=LRU_ENTRY_L1)
at
/usr/src/debug/nfs-ganesha-2.5.1-0.1.1-Source/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:691
#5 0x000000000051eac6 in lru_try_reap_entry () at
/usr/src/debug/nfs-ganesha-2.5.1-0.1.1-Source/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:718
Thanks,
Pradeep
On 8/7/17, GerritHub <supp...@gerritforge.com> wrote:
> From Daniel Gryniewicz <d...@redhat.com>:
>
> Daniel Gryniewicz has uploaded this change for review. (
> https://review.gerrithub.io/373094
>
>
> Change subject: Ensure partition lock and qlane lock ordering
> ......................................................................
>
> Ensure partition lock and qlane lock ordering
>
> Because of the initial ref path, the partition lock must be taken before
> the qlane lock. Ensure that all paths (noteably unref paths) take these
> locks in the correct order to avoid deadlock.
>
> Deadlock found by Pradeep <pradeep.tho...@gmail.com>
>
> Change-Id: I8abe86f6d3b6221c5221a29518504195718aa5f3
> Signed-off-by: Daniel Gryniewicz <d...@redhat.com>
> ---
> M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h
> M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
> M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h
> 3 files changed, 29 insertions(+), 31 deletions(-)
>
>
>
> git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha
> refs/changes/94/373094/1
> --
> To view, visit https://review.gerrithub.io/373094
> To unsubscribe, visit https://review.gerrithub.io/settings
>
> Gerrit-Project: ffilz/nfs-ganesha
> Gerrit-Branch: next
> Gerrit-MessageType: newchange
> Gerrit-Change-Id: I8abe86f6d3b6221c5221a29518504195718aa5f3
> Gerrit-Change-Number: 373094
> Gerrit-PatchSet: 1
> Gerrit-Owner: Daniel Gryniewicz <d...@redhat.com>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
