> On 8/22/17 3:07 PM, Frank Filz wrote: > >> On 8/11/17 4:38 PM, GerritHub wrote: > >>> Frank Filz has uploaded this change for *review*. > >>> > >>> View Change <https://review.gerrithub.io/373991> > >>> > >>> Remove support_ex FSAL method > >>> > >> Frank, I reviewed the simple removes, and even this one, but got > >> flummoxed where you change code to assume support_ex. I don't see > >> how this would be separate, or bisectible, from them. > > > > Once FSAL_ZFS was removed, all in-tree FSALs claim support_ex, so any > non-support_ex code paths are dead, and can be safely removed in bits and > pieces and in (almost) any order (I did remove from top of stack down, so > there should not be any linker failures). > > > Aha. The usual kernel technique is to batch the related patches [Patch > m/nn]), and a "Requires:" section with a list of the previous patch sets > needed to maintain order. > > My rough reading would be the ZFS patches submitted together, followed by > the Assumes patches submitted together, followed by the Remove patches > submitted together?
If you look at the related patches drop down in gerrithub, you can see the order the patches are in. Optionally, you can see my branch here: https://github.com/ffilz/nfs-ganesha/commits/gut Or you can actually download the branch from gerrithub: git fetch https://ff...@review.gerrithub.io/a/ffilz/nfs-ganesha refs/changes/98/373998/3 && git checkout FETCH_HEAD -b gut This is the last (HEAD) patch in the series: https://review.gerrithub.io/#/c/373998/ Frank --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
