We handle pull requests via gerrithub. There are full instructions in
src/CONTRIBUTING_HOWTO.txt but here are a couple important steps:
We also have several commit hooks, please install them:
src/scripts/git_hooks/install_git_hooks.sh
Install the Gerrithub change id commit hook
scp -p -P 29418 usernameh...@review.gerrithub.io:hooks/commit-msg
.git/hooks/
<mailto:usernameh...@review.gerrithub.io:hooks/commit-msg%20.git/hooks/>
To push to the project, we now use Gerrithub for code submission and review.
First, when creating a gerrithub account (first time sign-in), do NOT copy your
ganesha repo unless you plan to receive changes from someone else. It makes NO
sense to push changes to your own repo (except for the gatekeeper)
Now you have an account, you want to push some patch for us to review to
ffilz/nfs-ganesha - you need to start by adding a new remote.
You have a list of targets (anonymous http, ssh, http) to add on the project
page:
https://review.gerrithub.io/#/admin/projects/ffilz/nfs-ganesha
If your network allows it, ssh is easier. http needs you to setup a generated
password (settings page, "HTTP Password" menu on the left) Also make sure you
use https (not http)
so taking an example:
git remote add gerrit
ssh://usernameh...@review.gerrithub.io:29418/ffilz/nfs-ganesha
git fetch gerrit
git log gerrit/next..HEAD
This should ONLY list the commits you want to push! Also, all should have a
Change-Id.
Finally push your patches to Gerrithub:
git push gerrit HEAD:refs/for/next
That's it. If you edit a commit, just push it again, gerrit will notice it has
the same Change-Id and update your change with a new patch set. Please make
sure you don't change the Change-Id if you update the patch otherwise this
creates disconnected review.
If you want specific people to review your code, please go to Gerrithub and
add them.
Please note that you can only push changes to another repo that you wrote,
gerrithub will check the mail address you're using and ask you to add any
different mail address to your profile (settings -> Contact information).
Well, just read the text if you get an error, it's usually clear enough :)
Frank
From: Prashant Dhange [mailto:prashant.dha...@gmail.com]
Sent: Thursday, August 24, 2017 3:07 AM
To: nfs-ganesha-devel@lists.sourceforge.net
Subject: [Nfs-ganesha-devel] Pull request for FSAL_CEPH build fix
Hi,
I have submitted below fix for FSAL_CEPH build failure.
https://github.com/pdvian/nfs-ganesha/commit/63a58d79f4c886c9a70211cdacb3d1e00d855dd5
This is my first pull request for nfs-ganesha and new to process. Kindly help
me to submit this patch successfully.
Regards,
Prashant
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
