>From Jeff Layton <jlay...@redhat.com>:
Hello Soumya,
I'd like you to do a code review. Please visit
https://review.gerrithub.io/377711
to review the following change.
Change subject: Rework delegations to use new lease_op2 interface
......................................................................
Rework delegations to use new lease_op2 interface
This patch is heavily based on Soumya Koduri's original work to add a
new lease_op2 operation. The original proposal had quite a bit more
fields to handle reclaims, and different fields to handle setting
and removing and whether it was a read only delegation.
Ganesha never reclaims delegations, so I don't think we really need
that setting at this point. Also, the r/w setting is ignored when
we're removing a delegation. That leaves us with only 3 different
states for lease_op2 -- no delegation, read delegation, or read/write
delegation.
This proposed lease_op2 interface just takes an owner pointer and a
fsal_deleg_t enum, that is one of FSAL_DELEG_NONE, FSAL_DELEG_RD,
FSAL_DELEG_WR. I think this covers all of the use cases and is simpler
for FSAL's to get right.
Change-Id: I9ef314125c5eb86fd21c449787349b78f32da1df
Signed-off-by: Soumya Koduri <skod...@redhat.com>
Signed-off-by: Jeff Layton <jlay...@redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h
M src/FSAL/default_methods.c
M src/SAL/state_deleg.c
M src/include/fsal_api.h
M src/include/fsal_types.h
7 files changed, 86 insertions(+), 38 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha
refs/changes/11/377711/1
--
To view, visit https://review.gerrithub.io/377711
To unsubscribe, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ef314125c5eb86fd21c449787349b78f32da1df
Gerrit-Change-Number: 377711
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlay...@redhat.com>
Gerrit-Reviewer: Soumya <skod...@redhat.com>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
