> Frank Filz wrote on Wed, Sep 27, 2017 at 10:50:00AM -0700: > > One source of “fd leaks” is that the global fd, which is used for > > getattrs, is no longer well managed. I have some ideas in progress on > > how to better manage this, but discussion has stalled due to folks > > involvement in Bakeathon. > > > > > > > > If there is also a genuine leak of state_t associated with fids, that > > would be an issue. You might try running under Valgrind memcheck to > > look for leaks. > > No, this is definitely the former - I had a local patch that would not open > global fd but use a temporary FD in vfs_fsal_open_and_stat() that worked > ok-ish but I seem to have misplaced it. > Basically just always go through the default case of the switch statement in > that function will make it not use global fd for stats and fix the leak > Philippe > sees, but it's not a proper solution
Ok, then we definitely need a better solution to managing global fd, and we need to figure out what the most effective way to do stat on files if global fd is not already open. I think that can cause a lot of issues. Frank --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
