On 10/27/17 7:56 AM, Sachin Punadikar wrote:
Ganesha 2.3 got segfault with below :
[...]
After analyzing the core and related code found that - In "thr_decode_rpc_request" function, if call to SVC_RECV fails, then free_nfs_request is invoked to free the resources. But so far one of the field "reqdata->r_u.req.svc.rq_auth" is not initialized nor allocated, which is leading to segfault.

The code in this area is same for Ganesha 2.3 and 2.5.
I have created below patch to overcome this issue. Please review and if 
suitable merge with Ganesha 2.5 stable.
https://github.com/sachinpunadikar/nfs-ganesha/commit/91baffa8bd197c78eff106f42927a370155ae6b4

While your code should be harmless, at least in V2.5 that is already
initialized with gsh_calloc().  So it should already be NULL.

The answer of course as always is to upgrade....  There are a lot of
fixes in V2.4 and V2.5, the current stable branch!

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to