>From <[email protected]>:
[email protected] has uploaded this change for review. (
https://review.gerrithub.io/388782
Change subject: Set attributes_follow=false when required attributes are not
filled
......................................................................
Set attributes_follow=false when required attributes are not filled
Currently in nfs3_FSALattr_To_Fattr() when required attributes are
not filled we log a CRIT message, but do not tell the caller of
nfs3_FSALattr_To_Fattr() about the error. With this the caller sets
attributes_follow=true in the post_op_attr structure even in case of
partial or no attributes. With this there are chances that client will
see attributes_follow=true with partial or no attributes.
To avoid this we now return 'false' from nfs3_FSALattr_To_Fattr() to
tell that required attributes are not filled, thus letting the caller
take appropriate action for the same.
Change-Id: Ic2a1a994165664945161e88201b10f623b46b5b9
Signed-off-by: Madhu Thorat <[email protected]>
---
M src/Protocols/NFS/nfs3_readdirplus.c
M src/Protocols/NFS/nfs_proto_tools.c
M src/include/nfs_proto_tools.h
3 files changed, 19 insertions(+), 43 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha
refs/changes/82/388782/1
--
To view, visit https://review.gerrithub.io/388782
To unsubscribe, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2a1a994165664945161e88201b10f623b46b5b9
Gerrit-Change-Number: 388782
Gerrit-PatchSet: 1
Gerrit-Owner: [email protected]
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
