fsal_export should probably be set anywhere gsh_export is set.
Daniel On 12/07/2017 07:54 PM, Frank Filz wrote:
Stacked FSALs often depend on op_ctx->fsal_export being set. We also have lots of FSAL methods that take the fsal_export as a parameter. I wonder if we would be better off removing the fsal_export parameters in almost all cases, and instead expecting op_ctx->fsal_export to be set? One danger is that if an FSAL method is called for a different export than op_ctx->fsal_export, the subcall macros will end up changing op_ctx->fsal_export and break the caller... It would be better that the caller assure that op_ctx is properly set up (and save the current op_ctx->fsal_export if necessary). In any case, we probably need to audit anywhere op_ctx->fsal_export is not set. I see that RQUOTA does not set it... One advantage of making sure op_ctx->fsal_export is always set in the upper layers is that it should ALSO set op_ctx->ctx_export. We should also check for any place where op_ctx is NULL. We have subcall_shutdown_raw that assumes op_ctx might not be set, and the only place it is used is in calling sub_export release, with the result that that was not actually working right in the DBUS unexport case where there wasn't a proper op_ctx (though I wonder if that's also why shutdown reports an extra ref to FSAL_PSEUDO, is there some point in shutdown where we don't have an op_ctx?). Frank --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
