> On 11/27/17 1:47 PM, GerritHub wrote: > > [email protected] has uploaded this change for *review*. > > > > View Change <https://review.gerrithub.io/389184> > > > > Consolidate 9P queues and workers > > > > Move worker_thread and dispatch_thread queuing into 9P. > > This is no longer used by NFS RPC. > > > Is there some reason that this cleanup hasn't been merged? > > It was originally in a pair (with free_rpc_call). > > Dominique has reviewed it several times. I've responded to all the change > requests.... > > It's mostly moving code around, but it also fixes the dbus health counters > that had been removed over the past months. (Only 9P was updating them > anymore.) > > Anything this large is going to have future conflicts, so it would have been > better to get it out of the way.
If I miss the original e-mail announcing a patch, they can get lost... The Gerrithub dashboard doesn't show all the Ganesha patches, it shows the ones I'm a reviewer for... One simple thing folks can do to make sure I don't miss their patch: Add me as a reviewer. Now the patch will show up on my dashboard and is far less likely to be missed (though I have still managed to miss patches when there are a lot of patches). Another thing to do, if a patch has not received a +2 by Friday morning, or really even if it hasn't received a +2 within a day or two of getting other reviews, and I have not commented on the patch, ping me somehow (one way to ping me is choose this time as the time to add me a reviewer since that sends me an additional e-mail for the patch, if I'm already a reviewer, you can also add a comment to the patch). But a key is making sure I'm a reviewer on a patch, that makes sure it's on my dashboard, and I get an e-mail every time someone comments on the patch. In this case, I've added myself as a reviewer, and will review shortly. Frank --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
