On 01/30/2018 09:11 AM, William Allen Simpson wrote:
On 1/29/18 2:27 PM, Daniel Gryniewicz wrote:
On 01/29/2018 02:09 PM, William Allen Simpson wrote:
On 1/29/18 1:13 PM, GerritHub wrote:
Daniel Gryniewicz has uploaded this change for *review*.
View Change <https://review.gerrithub.io/397004>
Pullup ntirpc 1.6
(svc_vc) rearm after EAGAIN and EWOULDBLOCK
(Note, previous pullup was erroneously from 1.7)
All my weekend patches need to be backported to the 1.6 branch. There
are string errors and clnt_control errors fixed.
I'm not sure I agree. clnt_control() isn't called with unknown
values, so a default return of false isn't important; it's never
called with CLSET_XID, so that case isn't important. And RDMA doesn't
work, even with these fixes correct? I can't be convinced otherwise,
but it seemed the only important fix for 1.6 was the EAGAIN one.
Daniel
The error string commas are very important, as V2.6 does a lot more
error reporting now.
I think that clnt_control is important, especially given the bad error
returns and that this might be downstream for years. OTOH, it would also
apply to V2.5, V2.4, et alia going back years, and nobody has cared.
I agree we can hold off on RDMA for now (until next week).
Sorry you cannot be convinced otherwise.
(Sorry, typo, I meant to say I *can* be convinced otherwise.)
I agree about the comma patch, and have backported that. I'm not sure
how I missed it the first time around.
Daniel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
