On 1/31/18 3:11 PM, GerritHub wrote:
Frank Filz *posted comments* on this change.
View Change <https://review.gerrithub.io/397596>
It seems to me that the dupreq2_pkginit() is already in about the right
place, just after nfs_Init_client_id(). Moving it before doesn't do much.
Patch set 2:
(3 comments)
*
File src/MainNFSD/nfs_init.c:
<https://review.gerrithub.io/#/c/397596/2/src/MainNFSD/nfs_init.c>
o
Patch Set #2, Line 820:
<https://review.gerrithub.io/#/c/397596/2/src/MainNFSD/nfs_init.c@820>
|LogInfo(COMPONENT_INIT, "RPC resources successfully initialized");|
Hmm, should we do this after starting grace so we don't process
requests before setting up grace period?
OK, as long as it does not send NLM.
We need to move nfs_Init_admin_thread() down, because that starts dbus,
and dbus can start, terminate, and affect grace. So it should be here
after nfs_start_grace().
o
Patch Set #2, Line 823:
<https://review.gerrithub.io/#/c/397596/2/src/MainNFSD/nfs_init.c@823>
|fsal_save_ganesha_credentials();|
Hmm, this should be done earlier...
Where?
o
Patch Set #2, Line 962:
<https://review.gerrithub.io/#/c/397596/2/src/MainNFSD/nfs_init.c@962>
|nsm_unmonitor_all();|
Something makes me think this maybe needs to be earlier...
As to this last, you cannot do it until after nfs_Init_svc(), as it
makes client calls. Do you want it before or after nfs_start_grace()?
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
