>From <ka...@redhat.com>:
ka...@redhat.com has uploaded this change for review. (
https://review.gerrithub.io/400806
Change subject: build: replace archaic caddr_t with modern void *
......................................................................
build: replace archaic caddr_t with modern void *
Build fails on prerelease of Ubuntu 18.04 (bionic) because caddr_t is
no longer implicitly defined when <sys/types.h> is #included.
Trying to untangle the #ifdefs and #ifndefs in <features.h> and
<sys/types.h> (which is /usr/include/sys/types.h on redhatish linux
and /usr/include/{x86_64-linux-gnu,...}/sys/types on debianish linux)
it is revealed that caddr_t is defined when __USE_MISC #defined.
And __USE_MISC is #defined when either _DEFAULT_SOURCE is defined or
_GNU_SOURCE is defined. (_DEFAULT_SOURCE is/was a replacement for
_BSD_SOURCE and/or SVID_SOURCE which were deprecated in g(nu)libc some
time ago.)
Some combination of distributions implicitly or explicitly enabling
newer and stricter ANSI C compilation has resulted, in the case of
Ubuntu 18.04 anyway, caddr_t not being defined.
While it's possible that this is a transitory bug in Ubuntu 18.04's
headers (it hasn't reared its head on other bleeding edge linux
distributions like Fedora 28/rawhide, or Debian 20/Buster yet) it
seems marginally better to use void * instead; a) it's modern C, and
b) it's a built in type that won't or can't be broken by churn in
headers and feature tests.
Change-Id: Ie8eb79656fc5c3c48073b42f73bdcb92614b7c7c
Signed-off-by: Kaleb S. KEITHLEY <kkeit...@redhat.com>
---
M src/include/config_parsing.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha
refs/changes/06/400806/1
--
To view, visit https://review.gerrithub.io/400806
To unsubscribe, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8eb79656fc5c3c48073b42f73bdcb92614b7c7c
Gerrit-Change-Number: 400806
Gerrit-PatchSet: 1
Gerrit-Owner: ka...@redhat.com
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
