> Looking at the reply code just above this, discovered never executed code > section. I'm surprised the compiler isn't giving a warning. > > Checking the Lieb re-indent commit, there was a label handle_err. > > I'll go ahead and remove it. It merely seems to be old logging.... > Just a head's up for somebody to remember a need for this code.
I looked at the patch that removed the handle_err label. I'm not sure why I didn't remove the rest of this code at that time, but obviously it is dead code. Thanks for spotting it. Frank > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1411) > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1412) /* > Finish any > request not already deleted */ > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1413) if > (dpq_status > == DUPREQ_SUCCESS) > 00c21a6878 (William Allen Simpson 2015-06-12 07:36:46 -0400 1414) > dpq_status = nfs_dupreq_finish(&reqdata->r_u.req.svc, res_nfs); > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1415) goto > freeargs; > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1416) > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1417) /* > Reject the > request for authentication reason (incompatible > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1418) * file > handle) > */ > 822fdbc104 (Frank S. Filz 2014-03-20 15:01:31 -0400 1419) if > (isInfo(COMPONENT_DISPATCH) || isInfo(COMPONENT_EXPORT)) { > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1420) > char > dumpfh[1024]; > 33be2e2c11 (Frank S. Filz 2015-05-19 18:41:15 -0400 1421) > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1422) > sprint_fhandle3(dumpfh, (nfs_fh3 *) arg_nfs); > 822fdbc104 (Frank S. Filz 2014-03-20 15:01:31 -0400 1423) > LogInfo(COMPONENT_DISPATCH, > 66a09b1375 (Frank S. Filz 2017-12-07 11:30:32 -0800 1424) > "%s Request from host %s V3 not allowed on this export, proc=%" > 66a09b1375 (Frank S. Filz 2017-12-07 11:30:32 -0800 1425) > PRIu32 ", FH=%s", > ba42f03b2c (Frank S. Filz 2014-05-19 14:23:01 -0400 1426) > progname, client_ip, > eb51d7a97b (William Allen Simpson 2017-01-13 19:19:55 -0500 1427) > reqdata->r_u.req.svc.rq_msg.cb_proc, dumpfh); > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1428) } > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1429) auth_rc > = > AUTH_FAILED; > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1430) > 02526d7325 (Jim Lieb 2013-10-10 20:50:47 -0700 1431) > auth_failure: ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel