>From Jeff Layton <jlay...@redhat.com>:
Jeff Layton has uploaded this change for review. (
https://review.gerrithub.io/404231
Change subject: NFS: clean up loglevel handling in nfs4_Compound
......................................................................
NFS: clean up loglevel handling in nfs4_Compound
I suspect this is a gcc 7.x bug, but it doesn't seem to like the ?:
construct here:
In file included from
/home/jlayton/git/ganesha/src/libntirpc/ntirpc/rpc/xdr.h:52:0,
from
/home/jlayton/git/ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:53,
from /home/jlayton/git/ganesha/src/include/gsh_rpc.h:17,
from /home/jlayton/git/ganesha/src/include/uid2grp.h:44,
from /home/jlayton/git/ganesha/src/include/fsal_types.h:42,
from /home/jlayton/git/ganesha/src/include/fsal_api.h:43,
from /home/jlayton/git/ganesha/src/include/fsal.h:62,
from
/home/jlayton/git/ganesha/src/Protocols/NFS/nfs4_Compound.c:35:
/home/jlayton/git/ganesha/src/Protocols/NFS/nfs4_Compound.c: In function
‘nfs4_Compound’:
/home/jlayton/git/ganesha/src/Protocols/NFS/nfs4_Compound.c:697:27: error: ?:
using integer constants in boolean context, the expression will always evaluate
to ‘true’ [-Werror=int-in-bool-context]
bad_pos ? NIV_INFO : NIV_DEBUG,
/home/jlayton/git/ganesha/src/libntirpc/ntirpc/intrinsic.h:32:42: note: in
definition of macro ‘unlikely’
#define unlikely(x) __builtin_expect(!!(x), 0)
^
/home/jlayton/git/ganesha/src/Protocols/NFS/nfs4_Compound.c:696:4: note: in
expansion of macro ‘LogAtLevel’
LogAtLevel(COMPONENT_SESSIONS,
^~~~~~~~~~
Add a local variable and just override it if we get a bad_pos. Also,
tidy up the LogAtLevel defnition a bit.
Change-Id: I377bba595c38bf66d6bf34da714be923b685438b
Signed-off-by: Jeff Layton <jlay...@redhat.com>
---
M src/Protocols/NFS/nfs4_Compound.c
M src/include/log.h
2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha
refs/changes/31/404231/1
--
To view, visit https://review.gerrithub.io/404231
To unsubscribe, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I377bba595c38bf66d6bf34da714be923b685438b
Gerrit-Change-Number: 404231
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlay...@redhat.com>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
