On 03/23/2018 09:58 AM, William Allen Simpson wrote:
On 3/23/18 7:59 AM, Daniel Gryniewicz wrote:
Thanks, Tomk. PR is here: https://review.gerrithub.io/404945
Actually, it seems fairly elegant.
ntirpc and rdma also have the USE_ and _USE_ convention. Both
require libraries, and would benefit from defaults with
enforcement checking for the cmake parameter line.
How hard would it be to convert? Or would you prefer waiting
until these FSALs are pulled, and then try next week?
NTIRPC is a special case, since it's sometimes a submodule and sometimes
a library from the system. For this case, we have USE_SYSTEM_NTIRPC,
which will always fail if the package isn't installed.
I skipped RDMA this time, since it actually has 2 triggers: USE_NFS_RDMA
and USE_9P_RDMA. I have a list of cleanup/fixes to work on after this
bit drops, and RDMA is on that list to look at.
Daniel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
