Hello! On Tue, Nov 29, 2016 at 11:32:03AM +0200, Orgad Shaneh wrote:
> Hi, > > I'm not sure if this is the right place to do this. Please review and comment. > > # HG changeset patch > # User Orgad Shaneh <org...@gmail.com> > # Date 1480411801 -7200 > # Tue Nov 29 11:30:01 2016 +0200 > # Node ID 017b0c3afbbf960b9f29a892a82a77e9f17b6774 > # Parent e036a4628d9cc8803579d7d41848d528488eca6d > Use .exe for binaries for all win32 compilers > > diff -r e036a4628d9c -r 017b0c3afbbf auto/cc/conf > --- a/auto/cc/conf Tue Nov 29 09:37:45 2016 +0200 > +++ b/auto/cc/conf Tue Nov 29 11:30:01 2016 +0200 > @@ -144,7 +144,9 @@ > CFLAGS="$CFLAGS $NGX_CC_OPT" > NGX_TEST_LD_OPT="$NGX_LD_OPT" > > -if [ "$NGX_PLATFORM" != win32 ]; then > +if [ "$NGX_PLATFORM" = win32 ]; then > + ngx_binext=".exe" > +else > > if test -n "$NGX_LD_OPT"; then > ngx_feature=--with-ld-opt=\"$NGX_LD_OPT\" > Not sure it's at all needed. But if it is, it should be somewhere before per-compiler calls instead, e.g.: diff --git a/auto/cc/conf b/auto/cc/conf --- a/auto/cc/conf +++ b/auto/cc/conf @@ -17,6 +17,10 @@ ngx_objext="o" ngx_binext= ngx_modext=".so" +if [ "$NGX_PLATFORM" = win32 ]; then + ngx_binext=".exe" +fi + ngx_long_start= ngx_long_end= And also should imply removing ngx_binext from particular compilers. -- Maxim Dounin http://nginx.org/ _______________________________________________ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel
