On Fri, Jan 18, 2013 at 10:38:21AM +0200, Pasi Kärkkäinen wrote: > On Thu, Jan 17, 2013 at 11:15:58AM +0800, ?????? wrote: > > Yes. It should work for any request method. > > > > Great, thanks, I'll let you know how it works for me. Probably in two weeks > or so. >
Hi, Adding the tengine pull request 91 on top of nginx 1.2.7 doesn't work: cc1: warnings being treated as errors src/http/ngx_http_request_body.c: In function 'ngx_http_read_non_buffered_client_request_body': src/http/ngx_http_request_body.c:506: error: implicit declaration of function 'ngx_http_top_input_body_filter' make[1]: *** [objs/src/http/ngx_http_request_body.o] Error 1 make[1]: Leaving directory `/root/src/nginx/nginx-1.2.7' make: *** [build] Error 2 ngx_http_top_input_body_filter() cannot be found from any .c/.h files.. Which other patches should I apply? Perhaps this? https://github.com/cfsego/limit_upload_rate/blob/master/for-nginx.patch Thanks, -- Pasi > > > 2013/1/16 Pasi KÀrkkÀinen <[1][email protected]> > > > > On Sun, Jan 13, 2013 at 08:22:17PM +0800, ?????? wrote: > > >   This patch should work between nginx-1.2.6 and nginx-1.3.8. > > >   The documentation is here: > > > > >   ## client_body_postpone_sending ## > > >   Syntax: **client_body_postpone_sending** `size` > > >   Default: 64k > > >   Context: `http, server, location` > > >   If you specify the `proxy_request_buffering` or > > >   `fastcgi_request_buffering` to be off, Nginx will send the body > > to backend > > >   when it receives more than `size` data or the whole request body > > has been > > >   received. It could save the connection and reduce the IO number > > with > > >   backend. > > > > > >   ## proxy_request_buffering ## > > >   Syntax: **proxy_request_buffering** `on | off` > > >   Default: `on` > > >   Context: `http, server, location` > > >   Specify the request body will be buffered to the disk or not. If > > it's off, > > >   the request body will be stored in memory and sent to backend > > after Nginx > > >   receives more than `client_body_postpone_sending` data. It could > > save the > > >   disk IO with large request body. > > > > > > > > >       Note that, if you specify it to be off, the nginx > > retry mechanism > > >   with unsuccessful response will be broken after you sent part of > > the > > >   request to backend. It will just return 500 when it encounters > > such > > >   unsuccessful response. This directive also breaks these > > variables: > > >   $request_body, $request_body_file. You should not use these > > variables any > > >   more while their values are undefined. > > > > > > > Hello, > > > > This patch sounds exactly like what I need aswell! > > I assume it works for both POST and PUT requests? > > > > Thanks, > > > > -- Pasi > > > > >    Hello! > > >    @yaoweibin > > > > > >     If you are eager for this feature, you could try my > > >     patch: [2][2]https://github.com/taobao/tengine/pull/91. > > This patch has > > >     been running in our production servers. > > > > > >    what's the nginx version your patch based on? > > >    Thanks! > > >    On Fri, Jan 11, 2013 at 5:17 PM, Ã*Å Ã*°±ó > > <[3][3][email protected]> wrote: > > > > > >     I know nginx team are working on it. You can wait for it. > > >     If you are eager for this feature, you could try my > > >     patch: [4][4]https://github.com/taobao/tengine/pull/91. > > This patch has > > >     been running in our production servers. > > > > > >     2013/1/11 li zJay <[5][5][email protected]> > > > > > >      Hello! > > >      is it possible that nginx will not buffer the client > > body before > > >      handle the request to upstream? > > >      we want to use nginx as a reverse proxy to upload very > > very big file > > >      to the upstream, but the default behavior of nginx is > > to > > save the > > >      whole request to the local disk first before handle it > > to the > > >      upstream, which make the upstream impossible to process > > the file on > > >      the fly when the file is uploading, results in much > > high > > request > > >      latency and server-side resource consumption. > > >      Thanks! > > >      _______________________________________________ > > >      nginx mailing list > > >      [6][6][email protected] > > >      [7][7]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > >     -- > > >     Weibin Yao > > >     Developer @ Server Platform Team of Taobao > > >     _______________________________________________ > > >     nginx mailing list > > >     [8][8][email protected] > > >     [9][9]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > >    _______________________________________________ > > >    nginx mailing list > > >    [10][10][email protected] > > >    [11][11]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > >   -- > > >   Weibin Yao > > >   Developer @ Server Platform Team of Taobao > > > > > > References > > > > > >   Visible links > > >   1. mailto:[12][email protected] > > >   2. [13]https://github.com/taobao/tengine/pull/91 > > >   3. mailto:[14][email protected] > > >   4. [15]https://github.com/taobao/tengine/pull/91 > > >   5. mailto:[16][email protected] > > >   6. mailto:[17][email protected] > > >   7. [18]http://mailman.nginx.org/mailman/listinfo/nginx > > >   8. mailto:[19][email protected] > > >   9. [20]http://mailman.nginx.org/mailman/listinfo/nginx > > >  10. mailto:[21][email protected] > > >  11. [22]http://mailman.nginx.org/mailman/listinfo/nginx > > > > > _______________________________________________ > > > nginx mailing list > > > [23][email protected] > > > [24]http://mailman.nginx.org/mailman/listinfo/nginx > > > > _______________________________________________ > > nginx mailing list > > [25][email protected] > > [26]http://mailman.nginx.org/mailman/listinfo/nginx > > > > -- > > Weibin Yao > > Developer @ Server Platform Team of Taobao > > > > References > > > > Visible links > > 1. mailto:[email protected] > > 2. https://github.com/taobao/tengine/pull/91 > > 3. mailto:[email protected] > > 4. https://github.com/taobao/tengine/pull/91 > > 5. mailto:[email protected] > > 6. mailto:[email protected] > > 7. http://mailman.nginx.org/mailman/listinfo/nginx > > 8. mailto:[email protected] > > 9. http://mailman.nginx.org/mailman/listinfo/nginx > > 10. mailto:[email protected] > > 11. http://mailman.nginx.org/mailman/listinfo/nginx > > 12. mailto:[email protected] > > 13. https://github.com/taobao/tengine/pull/91 > > 14. mailto:[email protected] > > 15. https://github.com/taobao/tengine/pull/91 > > 16. mailto:[email protected] > > 17. mailto:[email protected] > > 18. http://mailman.nginx.org/mailman/listinfo/nginx > > 19. mailto:[email protected] > > 20. http://mailman.nginx.org/mailman/listinfo/nginx > > 21. mailto:[email protected] > > 22. http://mailman.nginx.org/mailman/listinfo/nginx > > 23. mailto:[email protected] > > 24. http://mailman.nginx.org/mailman/listinfo/nginx > > 25. mailto:[email protected] > > 26. http://mailman.nginx.org/mailman/listinfo/nginx > > > _______________________________________________ > > nginx mailing list > > [email protected] > > http://mailman.nginx.org/mailman/listinfo/nginx > > _______________________________________________ > nginx mailing list > [email protected] > http://mailman.nginx.org/mailman/listinfo/nginx _______________________________________________ nginx mailing list [email protected] http://mailman.nginx.org/mailman/listinfo/nginx
