Fabio?
Steve Wagner schrieb: > Hi Fabio, what do you men by "hard test" and should that test for > SchemaVerify or NH-1027? > > Steve > > Fabio Maulo schrieb: >> @SteveDo you can provide some hard test to pass ? >> >> I think that SchemaVerify will be a very useful feature; perhaps the most >> quickly way to verify existing DB with its mappings. >> >> 2008/11/16 Tuna Toksöz <[EMAIL PROTECTED]> >> >>> SchemaVerify is ready (with minor differences from the Hibernate) >>> SELF NOTE: >>> >>> NH ValidateSchema has some difference implementation from H >>> >>> /*NH Different Implementation : >>> TableMetadata tableInfo = >>> databaseMetadata.getTableMetadata( >>> table.getName(), >>> ( table.getSchema() == null ) ? defaultSchema : >>> table.getSchema(), >>> ( table.getCatalog() == null ) ? defaultCatalog : >>> table.getCatalog(), >>> table.isQuoted());*/ >>> ITableMetadata tableInfo = >>> databaseMetadata.GetTableMetadata( >>> table.Name, >>> table.Schema??defaultSchema, >>> table.Catalog,//??defaultCatalog, >>> table.IsQuoted); >>> >>> also >>> >>> NHibernate/Mapping/Table.cs >>> In ValidateColumns method >>> >>> //TODO: Add new method to ColumnMetadata :getTypeCode >>> bool typesMatch = column.GetSqlType(dialect, >>> mapping).ToLower() >>> .StartsWith(columnInfo.TypeName.ToLower()) >>> ; //|| columnInfo.get() == >>> column.GetSqlTypeCode(mapping); >>> >>> attention needed (probably tomorrow). >>> >>> >>> >>> On Fri, Nov 14, 2008 at 2:51 PM, Tuna Toksöz <[EMAIL PROTECTED]> wrote: >>> >>>> Ok, sure! >>>> >>>> >>>> On Fri, Nov 14, 2008 at 2:47 PM, Fabio Maulo <[EMAIL PROTECTED]>wrote: >>>> >>>>> 2008/11/14 Tuna Toksöz <[EMAIL PROTECTED]> >>>>> >>>>>> OK, creating Jira and start working on this after NH-1027 >>>>> If you are going to change Core classes remember to check our >>>>> implementation with Hibernate implementation and than comment the >>>>> difference >>>>> as: >>>>> //NH Different Implementation : ... what if is not so clear ..... >>>>> //NH Different behavior : ... which and why ..... >>>>> >>>>> We need it... believe me >>>>> >>>>> -- >>>>> Fabio Maulo >>>>> >>>> >>>> -- >>>> Tuna Toksöz >>>> >>>> Typos included to enhance the readers attention! >>>> >>> >>> -- >>> Tuna Toksöz >>> >>> Typos included to enhance the readers attention! >>> >> >> >
