Yes, it is a bug, please send us a patch for this

On Thu, Apr 16, 2009 at 6:07 PM, Dries Samyn <[email protected]>wrote:

>
> Hi,
>
> I am using the latest 2.0 release and I think I discovered a bug in
> the Mapping.Table class.
> The class has the following method:
>
> public string GetQuotedSchema(Dialect.Dialect dialect)
>                {
>                        return IsSchemaQuoted ? dialect.OpenQuote + schema +
> dialect.CloseQuote : schema;
>                }
> I believe this should be:
>
> public string GetQuotedSchema(Dialect.Dialect dialect)
>                {
>                        return IsSchemaQuoted ?
> dialect.QuoteForSchemaName(schema) :
> schema;
>                }
>
> The reason I found out about this is that I am using SqlCE as a db
> engine for my unit tests while using SQL Server 2005 in production. We
> want to use Schema to logically split different sections of the
> database. As it turns out, SqlCe doesn't support schemas.
> As we use SqlCe for unit testing only and the test generate the DB
> each time, I am not too worried about it using the schemas, so as a
> "hack" I wanted to generate a Dummy SqlCeDialect that basically
> overrides "QuoteForSchemaName" and returns null instead of the actual
> schema. While trying that out, I noticed this method doesn't get used.
>
> Would you agree this is a bug? Shall I send a patch through?
>

Reply via email to