Richard,

I tried to make simple patch where I read the data from XML file.

http://216.121.112.228/browse/NH-2232

I read the XML data using Dataset and created the database using the
same functions of CreateNorthwindData. In my tests the code is faster
than using SQL script option.

I have some doubts about the code below from CreateNorthwindData, I
think the superior of  employee is not persisted and I think this is
not the intention of the code, probably no tests need employee
superior.

 employees.Where(e => e.LastName == "Davolio").First().Superior =
employees.Where(e => e.LastName == "Fuller").First();
            employees.Where(e => e.LastName ==
"Leverling").First().Superior = employees.Where(e => e.LastName ==
"Fuller").First();
  ...

On Jun 22, 4:17 am, "Richard Brown \(gmail\)"
<[email protected]> wrote:
> If the function is staying (and I think it will need to stay to support
> arbitrary databases/dialects), then we'll need to fix it at some point.
> Remember, it works using the command-line tests too.
>
> Oh, and patches are always welcome.  ;-)
>
> --------------------------------------------------
> From: "Ricardo" <[email protected]>
> Sent: Tuesday, June 22, 2010 6:22 AM
> To: "nhibernate-development" <[email protected]>
> Subject: [nhibernate-development] Re: Linq readonly test overboost
>
> > and brings more maintenance work. Even if you wish to keep
> > ExecuteScriptFile , I think is a good idea to refactor
> > CreateNorthwindData for people that are using other databases that
> > does not have SQL scripts.

Reply via email to