I have tried it some years ago with FireBird. The matter is that you have to memorize which are the failing tests to be sure that nothing more was broken... The other matter is the target of such kind of work. Please, be sure to have a real clear target before start the work;somebody of us have to watch the buid server dialect per dialect, check what was changed, fix what is needed... perhaps the same work can be done in the local machine of the commiter in charge of a specific dialect.
-- Fabio Maulo El 07/12/2010, a las 07:18, "Richard Brown \(gmail\)" < [email protected]> escribió: Agreed, there is work to refactor the tests to get them all green (i.e., override the AppliesTo(Dialect) call). But I think we can live with maintaining a lit of ‘known’ failing ones in the short term. So instead of trying to get everything green (lots of work), we only allow things to get better (i.e., only fail if existing ‘green’ tests turn ‘red’, but ignore existing red ones). The AppliesTo() calls can get reviewed over time. *From:* Julian Maughan <[email protected]> *Sent:* Tuesday, December 07, 2010 10:14 AM *To:* [email protected] *Subject:* Re: [nhibernate-development] Failing Build Connection String Good question. Glenn Paulley (from Sybase) told me they are thinking of providing hosted (maybe on Amazon) versions of SQL Anywhere and ASE that we could use for testing. However, I'm not sure if Codebetter would allow our tests to connect to a database server outside of their network. So the other option (as you suggest) would be to see if Codebetter would host other database servers for us - personally, I'm a bit doubtful that they would. Another problem (which I mentioned to Glenn) is that our tests are mostly written to target SQL Server 2008. It would take quite an effort to refactor the tests to work with different/multiple databases. Having said that, I think it would be a healthy outcome if we did. On 7 Dec 2010 01:15, "Patrick Earl" <[email protected]> wrote: > Good to know Fabio. Thanks! > > BTW, does anyone know about the possibility of setting up databases other > than MSSQL on teamcity.codebetter.com? > > Would be nice if there were separate build configurations for different > databases so that even if all tests aren't supported, it would be easy to > see what's happening across the board. There are a million databases and > versions out there, so it would be hard to cover everything, but even having > recent versions of a few major ones would be helpful. > > Patrick Earl > > On Mon, Dec 6, 2010 at 9:39 AM, Fabio Maulo <[email protected]> wrote: > >> Each developer "should" have his hibernate.cfg.xml in >> the nhibernate\src\NHibernate.Test (and other tests). >> Before run tests the file is copied in the binaries folder and our TestCase >> will override the configuration defined in App.config with the configuration >> of hibernate.cfg.xml. >> Here is where is the magic >> private void Configure() >> { >> cfg = new Configuration(); >> if (TestConfigurationHelper.hibernateConfigFile != null) >> cfg.Configure(TestConfigurationHelper.hibernateConfigFile); >> >> I have 3 conf: >> FireBird.hibernate.cfg.xml >> MSSQL.hibernate.cfg.xml >> Oracle.hibernate.cfg.xml >> >> My override configuration for SQL server is: >> <hibernate-configuration xmlns="urn:nhibernate-configuration-2.2" > >> <session-factory name="NHibernate.Test"> >> <property >> name="connection.driver_class">NHibernate.Driver.SqlClientDriver</property> >> <property name="connection.connection_string"> >> Data Source=localhost\SQLEXPRESS;Initial Catalog=NHTEST;Integrated >> Security=True;Pooling=False >> </property> >> <property name="adonet.batch_size">10</property> >> <property name="show_sql">false</property> >> <property name="dialect">NHibernate.Dialect.MsSql2008Dialect</property> >> <property name="use_outer_join">true</property> >> <property name="command_timeout">10</property> >> <property name="query.substitutions">true 1, false 0, yes 'Y', no >> 'N'</property> >> <!--<property name="query.factory_class"> >> NHibernate.Hql.Classic.ClassicQueryTranslatorFactory, NHibernate >> </property>--> >> </session-factory> >> </hibernate-configuration> >> >> The adonet.batch_size is important because I would avoid some surprise (as >> as happened in the past). >> >> On Mon, Dec 6, 2010 at 1:31 PM, Fabio Maulo <[email protected]> wrote: >> >>> Personally I never used 'TestDatabaseSetup'. >>> >>> >>> On Mon, Dec 6, 2010 at 1:21 PM, Patrick Earl <[email protected]> wrote: >>> >>>> Looks like back in March, the connection string was hard-coded into >>>> NHibernate.TestDatabaseSetup/TestDatabaseSetup.cs to make the test database >>>> setup pass on the build server. That causes problems with running the tests >>>> from the NAnt scripts locally though, so I removed it realizing the build >>>> might fail. Indeed, the build has failed. Does anyone happen to have any >>>> thoughts on what the root cause of the problem might be? >>>> >>>> Patrick Earl >>>> >>> >>> >>> >>> -- >>> Fabio Maulo >>> >>> >> >> >> -- >> Fabio Maulo >> >>
