My best guess would be ... probably. Unfortunately the only database we
keep the tests running 100% on is SQL Server.
I'm hoping that we resolve that in the future (or at least get better at
it). In the meantime, if you can't run the tests again SQL Server, then
your best bet is to try and make sure that that number doesn't go up.
Also, the developer who eventually commits the changes will also be
responsible for running all the tests (against SQL Server) before checking
in too.
-----Original Message-----
From: Michael
Sent: Thursday, December 09, 2010 10:21 AM
To: nhibernate-development
Subject: [nhibernate-development] Re: PostSharp and static proxy
I've just run all the tests, without having modified NH's code base
yet.
I've used Firebird, as I don't have MSSQL installed on my computer.
411 on the 2847 tests failed. Is it... normal? Due to FB?
On 8 déc, 13:05, "Richard Brown \(gmail\)" <[email protected]>
wrote:
Yes, all the existing tests must pass, including the new test case that
demonstrates the desired behaviour.
-----Original Message-----
From: Michael
Sent: Wednesday, December 08, 2010 11:56 AM
To: nhibernate-development
Subject: [nhibernate-development] Re: PostSharp and static proxy
To check that my code is correct, which tests from NH's solution
should I run specifically?
All of them ? :)
On 8 d�c, 09:57, "Richard Brown \(gmail\)" <[email protected]>
wrote:
> Hi Michael,
> You can raise it as an improvement in JIRA.
> If you can put together a test-case demonstrating how NHibernate should
> behave using an example Entity and attach it to the JIRA that would be
> great.
> Cheers,
> Richard
> -----Original Message-----
> From: Michael
> Sent: Wednesday, December 08, 2010 8:41 AM
> To: nhibernate-development
> Subject: [nhibernate-development] Re: PostSharp and static proxy
> How should I do for the patch? I need to do it by myself and propose
> it when I'm done, or is there another procedure?
> On 7 d�c, 16:42, "Richard Brown \(gmail\)" <[email protected]>
> wrote:
> > Then I think we'd be talking about a patch to get NH to work in this
> > fashion
> > (AFAIK - someone correct me if I'm wrong).
> > How are lazy-loading of abstract classes handled? (Presumably they're
> > not?)
> > -----Original Message-----
> > From: Michael
> > Sent: Tuesday, December 07, 2010 3:32 PM
> > To: nhibernate-development
> > Subject: [nhibernate-development] Re: PostSharp and static proxy
> > No. There is one class, the entity, which PostSharp makes implement
> > INHibernateProxy by modifying the IL.
> > So all entities inherit from this interface. But the proxy-related
> > code is only executed when NH asks for it.
> > On 7 d�c, 16:12, "Richard Brown \(gmail\)" <[email protected]>
> > wrote:
> > > I'm possibly still missing something ... are there still two
> > > classes?
> > > (the
> > > 'real' one, and a second proxy one that inherits from it?)
> > > -----Original Message-----
> > > From: Michael
> > > Sent: Tuesday, December 07, 2010 2:35 PM
> > > To: nhibernate-development
> > > Subject: [nhibernate-development] Re: PostSharp and static proxy
> > > Because PostSharp implements this interface statically, on compile
> > > time. It doesn't create proxies on the fly like castle does, for
> > > example.
> > > On 7 d�c, 15:26, "Richard Brown \(gmail\)"
> > > <[email protected]>
> > > wrote:
> > > > Hi Michael,
> > > > I've no idea if this helps, but out of interest why do the
> > > > non-proxied
> > > > entities implement INHibernateProxy?
> > > > Richard
> > > > -----Original Message-----
> > > > From: Michael
> > > > Sent: Tuesday, December 07, 2010 2:11 PM
> > > > To: nhibernate-development
> > > > Subject: [nhibernate-development] PostSharp and static proxy
> > > > Hello all,
> > > > I've ported to PostSharp 2 and NH3 the bits ayende used to write,
> > > > to
> > > > use static proxies for the entities, instead of dynamic with
> > > > Castle
> > > > or
> > > > LinFu.
> > > > I was hopping not to have to modify the source code of NH, but
> > > > unfortunately I can't make the static proxies work without.
> > > > All the entities implement the INHibernateProxy interface, whether
> > > > they are proxied or not. The difference between a proxied entity
> > > > and
> > > > a
> > > > normal entity consists on the NHibernateLazyInitializer, which is
> > > > null
> > > > in the latter case, and not null in the former.
> > > > The problem I have is that in NH's code base, there are some
> > > > checks
> > > > on
> > > > the "proxyness" of an entity which rely only on the entity
> > > > implementing INHibernateProxy. This makes NH thinks that all the
> > > > entities are proxied, and leads to errors.
> > > > Ayende solved this problem with a few changes in NH's code base. I
> > > > thought I could avoid that, with the recent changes concerning the
> > > > decoupling from NH to the proxy part, but unfortunately I can't.
> > > > How should I fix that properly? Do I have to modify NH's bits?
> > > > Thanks in advance
> > > > Mike
