1) no problem, do what you think is better 2)no problem, do what you think is better 3) AFIK Properties is the plural of Property (not Propertys). Split refer to the action done for those columns. <join> is not supported by ORM and the action mean that you are splitting some properties from the base class-mapping-strategy. splitGroupId is because that is exactly the splitGroupId and, where not explicitly defined, it is use to give the name to the table. 4) <composite-id> in NH is used to represent two completely different concepts:
- a POID represented by a componed (in byCode it is ComponentAsId) - a POID composed by some properties of the entity (in byCode it is ComposedId) if we use the same name used in XML we will have a problem. IMO the byCode naming is more clear. On Sat, Jun 18, 2011 at 1:02 PM, Julian Maughan <julian.maug...@gmail.com>wrote: > I noticed a couple of naming issues on the ByCode mapping API: > > 1) ModelMapper.CompileMappingForAllExplicitAddedEntities -> better as > CompileMappingForAllExplicitlyAddedEntities? > 2) ModelMapper.CompileMappingForEachExplicitAddedEntity -> better as > CompileMappingForEachExplicitlyAddedEntity? > 3) IModelInspector.GetPropertiesSplits -> GetPropertySplits or > GetPropertysSplits? > 4) References to 'ComposedIds' mean 'CompositeIds'? > > For 1) and 2) it is better to say 'Explicitly' rather than 'Explicit', > although it is possible to get away with the current naming if there is a > real desire to save two characters in length :) > > Regarding 3), I'm not sure I understand the concept of 'splits' in the > code. It refers to <join> mappings I think? However, when I mapped a Join, > the parameter name for the table was 'splitGroupId' which seemed > unintuitive. > > Best to make any changes (if required) now than later... > -- Fabio Maulo
