That much is true.  Now we just need a volunteer to set up the
infrastructure for VB testing. ;)

       Patrick Earl

On Fri, Jul 15, 2011 at 3:28 PM, John Davidson <[email protected]> wrote:
> You should be able to create a vb-only test that compiles to its own dll and
> then run that test, rather than trying to recreate the expression tree,
> which may or may not be possible. There is no reason why tests cannot be
> mixed C# and VB. Doing so would actually add to the dependability of
> NHibernate.
> John Davidson
>
> On Fri, Jul 15, 2011 at 3:47 PM, Brian Pritchard <[email protected]>
> wrote:
>>
>> Ok, sorry, there is already an issue there:
>> https://nhibernate.jira.com/browse/NH-2545
>>
>> I will add comments to it.
>>
>> Thanks.
>>
>> On Jul 15, 2:45 pm, Patrick Earl <[email protected]> wrote:
>> > If you have not already, could you place check for and then create an
>> > issue?  If there's already an issue there, please add your discovered
>> > information to it.  We'll be looking for a failing test case as
>> > described in the jira issue.  This will be a bit of work to create
>> > since you'll need to get an expression tree that vb creates and then
>> > create that manually in C#.
>> >
>> > http://jira.nhforge.org/
>> >
>> >        Patrick Earl
>> >
>> > On Fri, Jul 15, 2011 at 11:07 AM, Brian Pritchard
>> >
>> > <[email protected]> wrote:
>> > > Hi, when doing a simple linq where clause in VB with a string
>> > > comparison (ex: Where customer.Name = "Fred") NHibernate throws an
>> > > exception on VBStringComparisonExpression not supported.
>> >
>> > > After googling around I found this by the remotion guys:
>> > >https://www.re-motion.org/blogs/mix/2010/07/15
>> >
>> > > So I got it to work by adding the following to
>> > > NHibernate.Linq.Visitors.NhExpressionTreeVisitor in the
>> > > VisitExpression method:
>> >
>> > > if (expression is VBStringComparisonExpression)
>> > > {
>> > >        return ((VBStringComparisonExpression)expression).Reduce();
>> > > }
>> >
>> > > My question is this the best place for this?  I tried hard without
>> > > success to find a way to handle this without modifying the source.
>> >
>> > > Also, are there any plans for NHibernate to support this nativley?
>> >
>> > > Thanks,
>> > > Brian
>

Reply via email to