Yes, please also file a JIRA issue that links to the pull request. Also put the JIRA link in the pull request.
On Thu, Nov 17, 2011 at 1:53 PM, Oskar Berggren <[email protected]> wrote: > As previously noted I have worked on porting the remaining parts of > the enhanced Id generators to NHibernate. > > The updates to the optimizers are now ready for review and hopefully merge. > Pull request: https://github.com/nhibernate/nhibernate-core/pull/26 > > What do you think? > > Is the procedure that I should also file a Jira issue about this, or > will the pull request be enough? > > I intend to finish porting the enhanced TableGenerator also, but I > figured I should submit this smaller part first, for easier review. > > > Details: > I have ported most of the changes made to the enhanced id generator's > optimizers since Fabio's initial port in 2008: > > Notably this adds the PooledLoOptimizer and fixes concurrency issues > in several optimizers. Tests are also ported (previously missing). > > I also change IAccessCallback.NextValue to be a method instead, to > follow what Microsoft's guidelines say about property getters free > from side effects. > > I have not included the LegacyHiloGenerator, as I'm unsure what > "legacy" refers to and if it's needed in NH. It can be added later if > there is interest. > > > /Oskar >
