I'm OK with that. I always find it more convenient when related tests are
together rather than grouped by JIRA (as long as the JIRA no. is in the
commit comment).
-----Original Message-----
From: Oskar Berggren
Sent: Tuesday, January 03, 2012 5:36 PM
To: [email protected]
Subject: [nhibernate-development] Fwd: [nhibernate-core] Fix for NH 2722 -
Linq Count() does not respect previous calls to Select() or Distinct() (#39)
I'm thinking that these tests should be integrated in the Linq tests,
instead of under NHSpecific, to keep tests of linq-features closer
together. Opinions?
/Oskar
---------- Forwarded message ----------
From: Alexander Zaytsev
<reply+i-2635366-0df7f1442ff1e660d1e654dfd16cd2762d0987ef-482...@reply.github.com>
Date: 2011/12/22
Subject: [nhibernate-core] Fix for NH 2722 - Linq Count() does not
respect previous calls to Select() or Distinct() (#39)
To: Oskar Berggren <[email protected]>
```
session.Query<DomainEntity>()
.Select(x => x.Property)
.Distinct()
.Count()
```
Results in a `count(*)` query being executed, rather than a
`count(distinct Property)` query.
```
session.Query<DomainEntity>()
.Select(x => x.Property)
.Count()
```
Results in a `count(*)` query, rather than a `count(Property)` query.
JIRA: https://nhibernate.jira.com/browse/NH-2722
You can merge this Pull Request by running:
git pull https://github.com/hazzik/nhibernate-core NH-2722
Or you can view, comment on it, or merge it online at:
https://github.com/nhibernate/nhibernate-core/pull/39
-- Commit Summary --
* Applied tests for NH-2722 from patch
* Implemented NH-2722
-- File Changes --
A src/NHibernate.Test/NHSpecificTest/NH2722/Entity.cs (10)
A src/NHibernate.Test/NHSpecificTest/NH2722/Fixture.cs (142)
A src/NHibernate.Test/NHSpecificTest/NH2722/Mappings.hbm.xml (10)
M src/NHibernate.Test/NHibernate.Test.csproj (3)
M src/NHibernate/Linq/ReWriters/MergeAggregatingResultsRewriter.cs (18)
-- Patch Links --
https://github.com/nhibernate/nhibernate-core/pull/39.patch
https://github.com/nhibernate/nhibernate-core/pull/39.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/nhibernate/nhibernate-core/pull/39
