1858 failing Tests?
On my machine and without my changes I had something slightly more than 500 (If
I remember correctly 512 or 514) out of the box but definitely not 1858!
Please let me know what TeamCity reports.
I didn’t look at the build server configuration but the Firebird driver needs
to be explicitly told that it should run in embedded mode.
This is done by setting the configuration attribute “ServerType” to a value of
1.
So the firebird connection string in this case should look something like:
Database=c:\nhibernate.fdb;
ServerType=1;
User=SYSDBA;Password=masterkey;
If you can please try this on your machine and let me know the result.
Von: [email protected]
[mailto:[email protected]] Im Auftrag von Oskar Berggren
Gesendet: Samstag, 18. Januar 2014 18:47
An: [email protected]
Betreff: Re: [nhibernate-development] Firebirds broken tests
The submitted fixes for NH-3586 (decimal precision on Firebird) and NH-3588
(fix DDL isolation for DBs where that is required) are merged. On my system the
number of failing tests for firebird went from 1858 to 1843. Teamcity appears
down at the moment so we'll have to wait and see what happens there. Thanks for
contributing!
Regarding the proposed build configuration changes: I thought we were already
using Firebird in embedded mode on the build server?
/Oskar
2014/1/14 Amro El-Fakharany <[email protected] <mailto:[email protected]> >
One example for the decimal issue is DecimalTypeFixture.
Examples for the parameter issue:
CriteriaQueryTests.OrderProjectionAliasedTest,
CriteriaQueryTests.OrderProjectionTest and CriteriaQueryTests.Subselect.
Amro
Von: [email protected]
<mailto:[email protected]>
[mailto:[email protected]
<mailto:[email protected]> ] Im Auftrag von Oskar Berggren
Gesendet: Montag, 13. Januar 2014 21:45
An: [email protected]
<mailto:[email protected]>
Betreff: Re: [nhibernate-development] Firebirds broken tests
2013/12/23 Amro El-Fakharany <[email protected] <mailto:[email protected]> >
Hi Everybody,
I noticed that there are some (actually a lot!) tests broken for Firebird and I
decided to tackle each Problem one by one.
So far I have found three Issues wich are (roughly description):
1) Decimal data type: Firebird does'nt support precisions larger than 18 and
the default of nh is 19.
I extended the FirebirdDialect to override the "GetTypeName" method and swap
larger Decimal precisions with 18.
2) Parameters Within a select clause: Firebird needs a typecast if a parameter
is used within a select clause.
I extended the FirebirdClientDriver to override the AdjustCommand method and
typecast the parameter.
Can you point to some existing tests that fails due to 1 and 2 above please?
/Oskar
--
---
You received this message because you are subscribed to the Google Groups
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to <mailto:[email protected]>
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
--
---
You received this message because you are subscribed to the Google Groups
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected]
<mailto:nhibernate-development%[email protected]> .
For more options, visit https://groups.google.com/groups/opt_out.
--
---
You received this message because you are subscribed to the Google Groups
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to <mailto:[email protected]>
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
--
---
You received this message because you are subscribed to the Google Groups
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
