Have you registered in JIRA?

2014-06-10 2:04 GMT+12:00 Jacob Levitt <[email protected]>:

> Thanks for the info! I still don't see how to add a comment to JIRA. There
> is no button to add a comment. Do I need special permissions to comment?
> Also, sorry for the double post. My post wasn't showing up for me last
> night. Must have been a google groups issue.
>
> Thanks again!
>
>
> On Monday, June 9, 2014 7:16:00 AM UTC-4, Alexander Zaytsev wrote:
>
>> Hi Jake,
>>
>> 1. To let people know you can write a comment on JIRA issue.
>> 2. If you want to make PR only with tests - that is perfectly fine, but
>> please mark those failing tests with [KnownBug] attribute, so CI would
>> expect them to fail. If the test come with fixes, then you dont need to
>> mark tests with [KnownBug].
>> 3. You create a branch for your fixes from master, and then submit pull
>> request from that branch.
>>
>> Happy contributing,
>>
>> Best Regards,
>> Alexander
>>
>>
>> 2014-06-09 13:01 GMT+12:00 Jacob Levitt <[email protected]>:
>>
>> Hi,
>>>
>>> How do I update a Jira issue? I've never contributed before, but decided
>>> it would be a cool thing to do. I found a bug in Jira (
>>> https://nhibernate.jira.com/browse/NH-3455) I'd like to fix and would
>>> like to update the bug report to let people know I'm working on it and
>>> already have created a failing test case.
>>>
>>> Is there anything else I should know about contributing? I've read the
>>> contributing guide (https://github.com/nhibernate/nhibernate-core/
>>> blob/master/CONTRIBUTING.md).
>>>
>>> A few other questions I have:
>>>
>>>    - Should I submit a PR with the test case now or wait until I have a
>>>    fix in place?
>>>    - When I submit a PR, should it be from my topic branch or should I
>>>    merge to my fork's master first?
>>>
>>>
>>> Thanks in advance!
>>>
>>> -Jake Levitt
>>>
>>> --
>>>
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "nhibernate-development" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to [email protected].
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>  --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "nhibernate-development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to