Yes, that's specifically where I started looking. Turns out it doesn't actually support altering or dropping columns just adding them.
On Wed, Jul 9, 2014 at 5:19 PM, Amro El-Fakharany <[email protected]> wrote: > Did you had a look at Configuration.GenerateSchemaUpdateScript method? > > Amro > Am 09.07.2014 22:43 schrieb "Jeffrey Becker" <[email protected]>: > > Issues are : >> >> NH-3633 - Add Support for Dropping Columns on Dialect >> NH-3632 - Add Support for AlteringColumns on Dialect >> NH-3631 - Add support for BatchTerminator on Dialect >> >> >> On Wednesday, July 9, 2014 1:32:34 PM UTC-4, Jeffrey Becker wrote: >>> >>> Understood. I'll have a JIRA issue opened "real soon now" with a pull >>> request to follow. Is one test fixture per property/method I'm adding with >>> tests for every dialect acceptable? >>> >>> I'm still a little concerned that I'm effectively asking for special >>> hooks into, from my perspective, the bowels of NHibernate in order to >>> support an external library. >>> >>> On Tuesday, July 8, 2014 2:59:35 AM UTC-4, Oskar Berggren wrote: >>>> >>>> If it involves larger structural changes you should outline them in >>>> text first. In any case you need to open at least one issue in JIRA, write >>>> the code with tests and submit pull requests. Try to structure the code in >>>> multiple logical commits for easier review. >>>> >>>> It's also good to consider if it can be done backwards compatible. >>>> >>>> /Oskar >>>> Den 8 jul 2014 02:37 skrev "Jeffrey Becker" <[email protected]>: >>>> >>>>> I've been playing around with writing a migration framework akin to >>>>> EF6 Migrations as a separate library and I've run into a number of places >>>>> sql flavors aren't adequately reflected in Dialect. Specifically I'm >>>>> running into issues around dropping & altering columns where the support >>>>> and syntax varies widely. What's the process for me proposing a change, >>>>> getting tests up to everyone's satisfaction and submitting a pull request? >>>>> >>>>> -- >>>>> >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "nhibernate-development" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >> >> --- >> You received this message because you are subscribed to the Google Groups >> "nhibernate-development" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > > --- > You received this message because you are subscribed to a topic in the > Google Groups "nhibernate-development" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/nhibernate-development/ACTD62W3eo0/unsubscribe > . > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- --- You received this message because you are subscribed to the Google Groups "nhibernate-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
