Nice work!

It was a while since I last looked at AdoNetWithDistributedTransactionFactory,
but I know it's been buggy a long time. IIRC, it seems to have been written
under the mistaken belief that the
TransactionCompleted event occurs synchronously (on the thread "owning" the
session and transactionscope).

2016-11-23 1:59 GMT+00:00 Alexander Zaytsev <[email protected]>:

> I've nailed it down it seems. There was a transaction leak through
> DistributedTransactionContext.AmbientTransaction property
>
> It seems that Oracle unmanaged provider is a good indicator of these
> transaction leaks. Currently I have only 2 tests failing because of
> "transaction rolled back" which I think I will solve shortly.
>
> Please see #489 for details.
>
> Best Regards,
> Alexander
>
> On Tue, 22 Nov 2016 at 9:50 PM, Alexander Zaytsev <[email protected]>
> wrote:
>
>> I'm experimenting. The Enlist=False did the trick, but we get no DTC at
>> all insted, which is not acceptable.
>>
>> I dont know where this closed/rolled back transaction is comming from
>> though.
>>
>> Best Regards,
>> Alexander
>>
>> On Tue, Nov 22, 2016 at 9:46 PM, Oskar Berggren <[email protected]
>> > wrote:
>>
>> Was that just luck though? The number of failing tests are back up again.
>>
>> 2016-11-21 22:58 GMT+00:00 Alexander Zaytsev <[email protected]>:
>>
>> I made #532. It solved the transaction rolled back issues. There are some
>> other. I'll look into them.
>>
>> But, do we really want "Enlist=False"?
>>
>> Thanks Ricardo!
>>
>> Best Regards,
>> Alexander
>> On Tue, 22 Nov 2016 at 12:30 AM, Ricardo Peres <[email protected]> wrote:
>>
>> I'll try.
>>
>> RP
>>
>>
>> On Monday, November 21, 2016 at 11:20:51 AM UTC, Oskar Berggren wrote:
>>
>> Ricardo, if you are able to submit a test PR with that change we can see
>> if it makes a difference.
>>
>>
>> 2016-11-21 11:17 GMT+00:00 Ricardo Peres <[email protected]>:
>>
>> Not sure if it's related, but there's a setting for Oracle to not promote
>> a transaction to distributed, therefore not using DTC. It's Enlist=false,
>> or something.
>> I had problems in the past and wrote a blog post about it:
>> https://weblogs.asp.net/ricardoperes/using-transactionscope-with-odp-net.
>> Sorry if it has nothing to do.
>>
>> RP
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "nhibernate-development" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "nhibernate-development" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> For more options, visit https://groups.google.com/d/optout.
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "nhibernate-development" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "nhibernate-development" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "nhibernate-development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to