Created https://github.com/nhibernate/nhibernate-core/pull/1820
On Monday, August 6, 2018 at 11:41:14 AM UTC-6, Matt Zinkevicius wrote: > > I am happy to make a pull request once I hear what an acceptable approach > would be. Perhaps I'll just make a PR that creates an NHibernate.Wcf > project/package and we can continue the discussion there? > > On Monday, August 6, 2018 at 12:23:24 AM UTC-6, Alexander Zaytsev wrote: >> >> Sorry Matt. >> On Mon, 6 Aug 2018 at 18:12, Alexander Zaytsev <[email protected]> wrote: >> >>> Hi Mark, >>> >>> Both of these options introduce a breaking change. We’ll try to estimate >>> an impact. >>> >>> Btw, pull requests are welcomed. >>> >>> Best Regards, >>> Alexander >>> On Mon, 6 Aug 2018 at 17:54, Matt Zinkevicius <[email protected]> wrote: >>> >>>> I don't think using reflection is an option in this case, since the >>>> code creates a class inheriting from a WCF interface. >>>> >>>> The only options I can think of is >>>> 1) Separating this context class out into its own project and NuGet >>>> package >>>> 2) Don't compile this context class in .NET Core 2.0+ builds, where the >>>> use of WCF is extremely uncommon >>>> >>>> >>>> On Saturday, August 4, 2018 at 11:17:28 AM UTC-6, Frédéric Delaporte >>>> wrote: >>>>> >>>>> This is required for the WCF session context >>>>> <https://github.com/nhibernate/nhibernate-core/blob/5.1.3/src/NHibernate/Context/WcfOperationSessionContext.cs>. >>>>> >>>>> A reflection based solution could be put in place instead, like the one >>>>> for >>>>> the Web session context >>>>> <https://github.com/nhibernate/nhibernate-core/blob/5.1.3/src/NHibernate/Context/WebSessionContext.cs>. >>>>> >>>>> (The reflection is done here >>>>> <https://github.com/nhibernate/nhibernate-core/blob/5.1.3/src/NHibernate/Context/ReflectiveHttpContext.cs> >>>>> .) >>>>> >>>>> Le samedi 4 août 2018 01:44:02 UTC+2, Matt Zinkevicius a écrit : >>>>>> >>>>>> Why does NH requires a package reference >>>>>> to System.ServiceModel.Primitives? This is a WCF library that bring in >>>>>> all >>>>>> kinds of dependencies (including an unmanaged one). >>>>>> >>>>>> Would it be possible to extract whatever code needs WCF support out >>>>>> of the main NH library and into a separate library/package? >>>>>> >>>>>> Thanks, >>>>>> Matt >>>>>> >>>>> -- >>>> >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "nhibernate-development" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- --- You received this message because you are subscribed to the Google Groups "nhibernate-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
