Ah, sorry - my fault! :)
Having never committed to the NH project if you don't mind I'll share
how I patched it here first to see if it makes sense (I'm poking
around the NH internals with a very newbie set of eyes). In the
OracleDataClientBatchingBatcher I wrapped the
currentBatch.ExecuteNonQuery() call with a try..catch, rethrowing the
converted exception:
try
{
rowsAffected = currentBatch.ExecuteNonQuery();
}
catch (Exception sqle)
{
throw Convert(sqle, "Could not cancel query");
}
My own app tests show that it does the trick, but I'm not sure what I
might have broke. I suspect your answer will be to check out the NH
source with tests, make the change, run all the tests, and then create
a patch?
Cheers,
Colin
On Sep 17, 5:43 pm, Fabio Maulo <[email protected]> wrote:
> Hi!
> I said "It is" and not "it was" ;)
> patch welcome
>
>
>
>
>
> On Fri, Sep 17, 2010 at 6:04 PM, Colin Bowern <[email protected]> wrote:
> > Beyond the added logging code I'm not seeing any fixes in the head of
> > the trunk?
>
> >http://nhibernate.svn.sourceforge.net/viewvc/nhibernate/trunk/nhibern...
>
> > Where was the bug addressed?
>
> > On Sep 16, 6:56 pm, Fabio Maulo <[email protected]> wrote:
> > > It is a bug inside the OracleBatchingBatcher
>
> > > On Thu, Sep 16, 2010 at 7:28 PM, Colin Bowern <[email protected]> wrote:
> > > > Just noticing a new behavior - when I enable batching by settings the
> > > > adonet.batch_size, NH throws the raw exception from the ADO.NET driver
> > > > (in my case an OracleException from ODP.NET). It doesn't run it
> > > > through the ISQLExceptionConverter class wired in as I would expect.
> > > > If I disable batching it does execute the converter class.
>
> > > > Is this by design? Any suggestions on converting exceptions in
> > > > batching scenarios?
>
> > > > --
> > > > You received this message because you are subscribed to the Google
> > Groups
> > > > "nhusers" group.
> > > > To post to this group, send email to [email protected].
> > > > To unsubscribe from this group, send email to
> > > > [email protected]<nhusers%[email protected]>
> > <nhusers%[email protected]<nhusers%252bunsubscr...@googlegroups.com>
>
> > > > .
> > > > For more options, visit this group at
> > > >http://groups.google.com/group/nhusers?hl=en.
>
> > > --
> > > Fabio Maulo
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "nhusers" group.
> > To post to this group, send email to [email protected].
> > To unsubscribe from this group, send email to
> > [email protected]<nhusers%[email protected]>
> > .
> > For more options, visit this group at
> >http://groups.google.com/group/nhusers?hl=en.
>
> --
> Fabio Maulo- Hide quoted text -
>
> - Show quoted text -
--
You received this message because you are subscribed to the Google Groups
"nhusers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/nhusers?hl=en.
