Excerpts from ludo's message of Wed Jun 16 23:04:12 +0200 2010: > >> I see this factorization benefit. However, wouldn’t it work to use > >> ‘makeFlags’ for ‘-j’ flags?
Sorry, I forgot to reply to this. No because makeFlags would be added to all phases, correct? > > It would. That's when opt-out starts mattering. How would you implement > > opt-out > > for each phase then? > > I don’t think ‘-j’ matters outside of ‘buildPhase’, so I don’t see the > need for per-phase options. Maybe there are some packages where it matters when running make check? > > $curPhase is set by the builder anyway. This leads to the names being > > disliked by Eelco Dolstra: NO_PARALLEL_BUILD_buildPhase etc: > Yes, it sucks IMO too. Can we shorten this discussion? Somehow I have to decide whether I should keep this in a private branch or not. It is important to me so I will keep and maintain it anyway. If I have to keep it in a separate branch I can longer use the buildfarm (or I have to build / setup my own..) We have 2 options: a) revert b) improve If you'd like to improve this patch may I ask you to start from scratch and paste your diff? Probably this is faster than talking about each line. Marc Weber _______________________________________________ nix-dev mailing list [email protected] https://mail.cs.uu.nl/mailman/listinfo/nix-dev
